Peter Solnica

icon indicating a website link https://solnic.dev

icon company @getsentry icon location Kraków icon location 👨‍💻 Elixir/Ruby SDK dev at @getsentry 💜 Creator of Elixir Drops 💦 ❤️ Creator of @rom-rb and many @dry-rb gems and former @hanami core team member

Results 573 comments of Peter Solnica

traceparent support

@kubosuke it's a WIP, I'll be opening a PR before the end of the week, got it working already just need to clean up the implementation :)

exception happened in background worker: source sequence is illegal/malformed utf-8

@grosser thanks for the report. Any chance you could give me an example message that causes this? We do have handling of malformed utf-8 strings in place.

exception happened in background worker: source sequence is illegal/malformed utf-8

@grosser alright, I'll dig into it - could you tell me what exact custom logger do you use that does `{message: message}.to_json`?

exception happened in background worker: source sequence is illegal/malformed utf-8

@grosser how exactly do you configure this logger in Sentry config?

feat: Client that uses Req.

Thanks for the PR but for the time being we're not planning to maintain more clients. We may revisit this in the future when there's clearly demand for it though.

Guard job arguments behind `send_default_pii`

@sl0thentr0py maybe we could do this along with the general bg job refa work in 7.0?

LogEvent does not correctly handle nested attributes (e.g., Rails ActionController params)

@vivekmiyani thank you for reporting the issue and offering help ❤️ Please feel free to open a PR and using `JSON` like you mentioned. The subscriber is using params filtering...

Vernier + profiling enabled causing silent crashes

Thanks for reporting this Adam 🙇🏻 I'll be looking into this today, but since this is coming from Vernier I'm afraid I won't be able to fix it quickly. One...

RuntimeError: profile not started from a Sidekiq worker when profiling is enabled (Vernier)

Thanks for the report. I'll look into this!

RuntimeError: profile not started from a Sidekiq worker when profiling is enabled (Vernier)

I'm having trouble reproducing this exactly, but I did manage to see Vernier breaking when there's more than one worker running. I still need to investigate what exactly causes this....