Peter Solnica

Results 573 comments of Peter Solnica

> @solnic we're not requiring the new `sentry/vernier/profiler` anywhere? We should not force end users to require another obscure path from within the gem, they should all be setup internally....

> I tried on a simple rails controller with some database calls and the profile is not sent due to being oversized. > However, the [size limits](https://develop.sentry.dev/sdk/envelopes/#size-limits) for a profile...

@sl0thentr0py alright this is now using the increased envelope profile item limit

@sl0thentr0py yessssss! Thanks for the reviews and testing! Let's 🚒 it πŸ˜„

Does this happen regardless of what is configured within that init block?

Alright, please provide us with more info. A stacktrace would be helpful.

Thanks @zachdaniel - I like the idea behind igniter. The only concern here is that having it officially in the SDK adds a little bit of extra maintenance burden for...

@zachdaniel if we could count on you to help us with maintenance then I think it's reasonable, but it's not my call at the end of the day. @sl0thentr0py please...

> > Not very popular yet, but this is not a lot to maintain (and it might become popular). > > I'm not being defensive I promise, but it depends...

> I'm assuming yanking 1.13 from CI is off the table πŸ˜… Yes we need to support it. Let's just move igniter tests to test_integration - we only run them...