Peter Solnica comments

Results 573 comments of


                                            Peter Solnica

RescuedExceptionInterceptor: Handle empty configuration

Sorry but I'm having second thoughts about this, it's the same as I outlined here https://github.com/getsentry/sentry-ruby/pull/2396#issuecomment-2440715857

RescuedExceptionInterceptor: Handle empty configuration

> I've had a quick look at the two test failures. The [second one](https://github.com/getsentry/sentry-ruby/actions/runs/11506103055/job/32170476742?pr=2428) is caused by Docker Pull Limits, the first one failed when setting up Ruby 2.5. Both...

Add support for :skip_retries config option to Oban.ErrorReporter

@whatyouhide on hold until I have time for this, which is after distributed tracing and structured logging, as these are my priorities now.

Attributes on struct (but not relation) raises error when defining a Factory

Factories are defined based on relation schemas, not struct schemas. If we wanted to support projected attributes we'd need a way of telling the factory that they exist. This can...

Attributes on struct (but not relation) raises error when defining a Factory

We could have a DSL for defining factories for custom structs too, like `MyFactory.define(Article) do ...`

Associations in traits persists multiple times

Thanks for reporting this! I'll look into it.

Mixing optional and bare field names results in function clause error

Thanks for reporting this. I'll get that fixed!

WIP otel auto setup

@sl0thentr0py I suppose this should be closed in favor of #784?

Better `:in_app_module_allow_list` default

> we could use `:application.get_key(app, :modules)` to get all the app modules. @whatyouhide could you tell me what would be a good way of resolving what `app` is? It seems...

Custom fingerprint added to GenServer call crashes by client

Thank you for this detailed report! @whatyouhide what's the reasoning behind including args in the fingerprint?