Peter Solnica comments

Results 573 comments of


                                            Peter Solnica

Allow for option to override association factory name

Please provide a reproduction script

Inconsistent behaviour with default schema values in factories

Thanks for reporting and isolating the issue. I'm working on rom 6.0 at the moment but rom-factory will be greatly improved and upgraded along with rom 6.0. I will make...

Overriding attributes doesn't affect dependent attributes

Thanks for reporting this. I'll be revisiting this gem in general just before rom 6.0 / hanami 2.0 so hopefully I'll address all the known issues. In the meantime....help-wanted 🙂

Allow usage of relations in dependant attributes

Can you show an example? I'm not sure I understand.

Allow usage of relations in dependant attributes

@alexandru-calinoiu kind of yes, a sample setup that shows the problem would be more helpful though. Are you saying that in this case `factory[:scheduled_position].position_id` returns `nil`?

overriding factory attributes is causing related field callbacks to fail

Thanks for reporting this, clearly a bug. I think we should re-think this API in general. Yielding attribute values via block args can be problematic when you have attributes that...

overriding factory attributes is causing related field callbacks to fail

@flash-gordon yeah...seems like a pragmatic choice. I wonder though....maybe we could provide a struct with values that are lazy, this way you could still rely on more than one value...

Notify developer for not used subscribers

This sounds like a good idea.

Thread variables are not accessible

I agree this should be properly explained in the docs. Even if it's an edge-case it deserves an explanation.

Thread variables are not accessible

Is this a problem only in case of the State effect?