Peter Solnica

Results 573 comments of Peter Solnica

To be honest, this seems like an edge case. Using multiple injection modules in the same class isn't an intended usage. It shouldn't cause an exception though. Maybe we should...

I'd say `Any` would be a better name. WDYT?

I think it's worth getting this into 1.0.0. Getting confusing exceptions can be frustrating for the users, especially people who are trying out dry-system/hanami2 for the first time. Using acronyms...

@timriley yeah I know thanks! Verifying constants is a good thing to do, mismatches will happen. We could maybe either have it done by default or have a special verbose/verification...

^5 @moonglum

@cflipse is this still needed?

@ianks this makes sense, as a side-note - IIRC it's something rom-elasticsearch would benefit from too, so I suspect this will end up in the core at some point.

@ianks let's start here and see how it goes 🙂

@flash-gordon you mean, from a rom *user* point of view, right?