Solar Designer

My comment on that hack included: > ```diff > * Tell our originally 32-bit ARM code that we sort of have NEON. > ``` which reminds me of the reason...

> I thought I already added the H/H2 split. As I understand: to MD5 yes, to MD4 not yet.

A relevant question for us: do we still want to be able to use OpenSSL's MD[45] as well? I doubt it. While OpenSSL might provide assembly implementations, it also zeroizes...

> Are we talking about same thing? Ah, right. So the H/H2 is already in there. Don't know how I missed that.

> Where can I find your upstream code? https://openwall.info/wiki/people/solar/software/public-domain-source-code But I guess I'll take care of this issue myself.

BTW, this provides some speedup for formats that copy contexts, such as SIP (as reminded by #1990), EIGRP, HSRP, tacacs-plus: ```diff +++ b/src/md5.h @@ -34,7 +34,9 @@ typedef struct {...

> do we still want to be able to use OpenSSL's MD[45] as well? I doubt it. While OpenSSL might provide assembly implementations, it also zeroizes memory on `*_Final`, which...

> So the H/H2 is already in there. Don't know how I missed that. Looks like while the H/H2 split for MD4 is in here, it is not in my...

For now, I am going to reduce the differences from upstream, not sync to the extent I'd eventually like. While doing this, found a bug: in our changes here, we...

> According to comments in that thread, it works fine. Right, but then why did OP say it didn't ("When ever i use rar2john on a single file i get...