Brett Sun
Brett Sun
@leftab Because this wasn't pulled into some of the minor aragonOS 4.x releases, due to the incompatible bytecode (and because we didn't want to risk re-deploying the ACL for 0.7),...
> 1. Switching off the `IssuesRegistry` With the current implementation this actually wouldn't be possible (as none of its methods are `killSwitchProtected`), but I agree we should be set up...
> Therefore my proposal of moving forward with an MVP implementation assuming that the Kernel, ACL, KillSwitch and the "root authority" apps will be whitelisted. The problem with just whitelisting...
@dapplion > Regarding `AppProxyFactory.newPinnedAppProxy(IKernel, bytes32)` are you referring to `newAppProxyPinned`? Oops, yes! I've edited the issue :). > Regarding EVMScriptRunner.protectState, since DelegateScript and DeployDelegateScript executors removed, is it possible to...
First of all, thanks for contributing to the tests! ❤️ > AppProxyFactory.newPinnedAppProxy(IKernel, bytes32) is never called by the kernel or any contract, in contrast to AppProxyFactory.newAppProxyPinned(IKernel, bytes32, bytes) I'd say...
Ahhh good point! It was once ignored in coverage due to solidity-coverage not supporting some assembly opcodes, but this has been fixed and we should increase the coverage of SafeERC20...
I think the biggest part of this confusion is due to how these variables are named. `ANY_ENTITY` should've really been named `ALL_ALLOWED` and `BURN_ENTITY` as `BURN_MANAGER`. These two particular constants...
@juslar Nice! I think the backwards-compatible version isn't a terrible cost to swallow, and we should make sure to comment it. An interesting thing we might want to set up...
> Do you have an idea how I could cover this? Is it ok to leave it this way? See https://github.com/aragon/aragonOS/pull/459#discussion_r247033374; most of the time that check should be covered...
@juslar Because this wasn't pulled into some of the minor aragonOS 4.x releases (and because we didn't want to risk re-deploying the ACL for 0.7), we'll roll this into aragonOS...