Brett Sun

Add an option for adding NODE_ENV checks for minifiers

3

Consumers of a library should be able to access the library's proptypes in dev builds, but then be able to seamlessly strip them out for production. See conversation on https://github.com/brigand/babel-plugin-flow-react-proptypes/issues/70#issuecomment-278551711....

Importing type from local file is left unresolved by rollup

2

In ComponentA.js: ```js ... export type ComponentAType = string ... ``` This gets transpiled with the plugin to: ```js var babelPluginFlowReactPropTypes_proptype_ComponentAType$1 = require('prop-types').string; if (typeof exports !== 'undefined') Object.defineProperty(exports, 'babelPluginFlowReactPropTypes_proptype_ComponentAType',...

allow inline configuration through comment directives

10

There are a number of cases where one or more functions in a contract may be in a different order than the recommended visibility order due to logical grouping; one...

Extend visibility-first to also check constants

2

Constant definitions should also be checked by `visibility-first` (or an alternative rule) so that their visibility modifiers come first.

chore: prefer utilities provided by aragonUI

1

We currently have some utilities copied from aragonUI in a number of the apps, but we should prefer directly importing them from aragonUI instead (for example, `shortenAddress`).

[DO NOT MERGE] Track @next contract changes

1

To be externally reviewed.

Agreement, DisputableVoting: add aragonPM publish configuration

2

Adds the Aragon buidler plugin and configuration for aragonPM publishing. To publish, I've been using: ``` npx buidler publish --network --skip-validation ```

Finance: automatically add installed Token Managers' tokens to tracked tokens

1

With the new `getApps()` API exposed in `@aragon/api`, the Finance app can now detect installed Token Managers and include their tokens automatically in its tracked list of token balances.

**To decrease noise, we use this issue to collect and curate potential improvements to the apps' underlying smart contracts.** All other issues are closed and re-routed into here. This is...

From internal reviews and security audits: - [ ] [Fix signature malleability](https://github.com/aragon/aragon-apps/pull/611#discussion_r266572130) - [ ] `isValidSignature()` changes: [1](https://github.com/aragon/aragon-apps/pull/611#discussion_r259084569), [2](https://github.com/aragon/aragon-apps/pull/611#discussion_r260852403), [3](https://github.com/aragon/aragon-apps/pull/611#discussion_r262164234) - [x] [Update in case ERC1271 changes](https://github.com/aragon/aragon-apps/pull/611#discussion_r260858172) - [ ]...