Brett Sun

Results 199 comments of Brett Sun
trafficstars

Removing from mainnet scope due to requirement on https://github.com/aragon/aragon/issues/363.

Long names may be a problem for overflowing—we can use a rule based on the length of the name. If the name is too long, fallback to displaying the symbol.

We've been a bit slow in updating this particular illustration because most organizations don't start with empty tokens apps :).

@bpierre > Should we always use the full name, and use text-overflow: ellipsis in the menu (I think it’s already the case)? I was worried in the case of some...

> I think we might want to do this at the UI level? That way, we would be able to use a title with the full name for example. The...

This might also be alleviated if we use https://github.com/rkalis/truffle-assertions.

Now that aragon.js is going to be a monorepo for all JS-related libs and packaging, it probably makes most sense for these test-helpers to be moved there.

Move to https://github.com/aragon/contract-helpers.

Actually a much better way of doing this optimization is just to avoid fetching past events at all, since the getters will already be able to tell us everything we...

Hmm, this is quite awkward and shouldn't be the case. Maybe there's something weird with how we're memoizing but the balances should definitely be updating.