aragon-apps icon indicating copy to clipboard operation
aragon-apps copied to clipboard

Token Manager: Identify using token name rather than symbol

Open fabriziovigevani opened this issue 4 years ago • 6 comments

closes #1061

Do you think 16 characters is a reasonable max length for a token name?

I thought of the length not being so long where it could take almost all space available it has.

fabriziovigevani avatar Apr 10 '20 15:04 fabriziovigevani

Thanks for opening this pull request! Someone will review it soon 🔍

welcome[bot] avatar Apr 10 '20 15:04 welcome[bot]

Should we always use the full name, and use text-overflow: ellipsis in the menu (I think it’s already the case)?

bpierre avatar Apr 10 '20 16:04 bpierre

Ah yes good point

fabriziovigevani avatar Apr 10 '20 16:04 fabriziovigevani

@bpierre

Should we always use the full name, and use text-overflow: ellipsis in the menu (I think it’s already the case)?

I was worried in the case of some Tags, e.g. in Permissions, that render the Token's identifier overfilling.

sohkai avatar Apr 10 '20 16:04 sohkai

I was worried in the case of some Tags, e.g. in Permissions, that render the Token's identifier overfilling.

I think we might want to do this at the UI level? That way, we would be able to use a title with the full name for example.

bpierre avatar Jun 04 '20 00:06 bpierre

I think we might want to do this at the UI level? That way, we would be able to use a title with the full name for example.

The problem with trying to do this at the UI level is that app identifiers are treated as an abstract concept by the Client and cannot assume fallbacks or etc based on text length (at least, at the moment).

sohkai avatar Jun 07 '20 23:06 sohkai