Tony Mountifield
Tony Mountifield
Great, I'll do a final smoke test of the artifact and then merge.
Just built this on RPi and tried it out. Works fine. I noticed that it now saves `Jamulus.ini` on state changes, such as moving the main window, or exiting from...
This change seems to break registration with a directory in GUI servers. See https://github.com/jamulussoftware/jamulus/issues/3287#issuecomment-2197726812
@dependabot rebase
Not sure why the CI failed on this. It says: [Error: .github#L1](https://github.com/jamulussoftware/jamulus/commit/d469bf0e15af22ee0f64326a21085f3733663fd3#annotation_18830681558) `actions/download-artifact@v4 is not allowed to be used in jamulussoftware/jamulus. Actions in this workflow must be: within a repository...
There might be more changes needed to support this version. See [download-artifact](https://github.com/actions/download-artifact) and [MIGRATION.md](https://github.com/actions/download-artifact/blob/main/docs/MIGRATION.md).
@dependabot rebase
> I think that's a security violation. You'll need to allow the new action in this repos settings. Ah yes, I found that it was listing `actions/download-artifact@v3` as allowed, so...
Well the job ran successfully this time: https://github.com/jamulussoftware/jamulus/actions/runs/8159077748 But the `download-artifact` action is only used in **Create files for .deb repository**, which is skipped unless we are building a release....
> But the `download-artifact` action is only used in **Create files for .deb repository**, which is skipped unless we are building a release. So in order to test the new...