Tony Mountifield
Tony Mountifield
After reviews, I will squash to a single commit before merging. I have left the original commits for review, to show the process of arriving at the solution. Before the...
And similarly after the final commit: - https://github.com/emlynmac/jamulus/actions/runs/2070442079 - https://github.com/softins/jamulus/actions/runs/2070443008
> Another thing to consider: @ann0see already introduced a way to run CodeQL on the legacy build (downside: we have to take care of that when removing that, but there's...
> > Requires API users to request the current data first and pre-fill the fields which should not be changed. Maybe we could make the fields optional, though? > >...
> > I would agree. Allow a subset of the params to be given, and only change the ones that were given. > > We'd have to keep it possible...
> @softins can you help out with some potentially network (server) related? Not until next week. I'm away on holiday until Saturday. You could send details through in the meantime...
> I'm only unhappy because, whilst it might work, there are high level design issues... That may or may not be the case. The PR #2774 fixing the current issue...
Currently in Qt < 5.12, compilation still succeeds, but no translations are available in the executable.
> Is the legacy MacOS build affected? Yes, at the moment it would build but have no translations. So if we want to continue legacy support in 3.9 there is...
> @softins this needs to be rebased. Yes, I still haven't worked out what to do about embedding translations for Qt < 5.12. I haven't yet got it to work,...