Sven Nierlein

Seems like there is no test case at all for check_mailq.pl :/

I like the idea, but right now it turns all integers into floats (see the failed tests). So i'd suggest to only apply the multiplier if its not 1. Also...

could you please rebase onto latest head, travis tests should be much more stable now.

maybe not magically but with https://github.com/monitoring-plugins/monitoring-plugins/pull/1388 So could you try the "latest" master branch to see if it helps?

That's probably not the hole patch. Right now services are not checked at all.

i don't think the above code counts as "intellectual property" already, so i wouldn't worry too much about it.

You might want to have a look at the check_nwc_health plugin. Afaik this plugin is capable of using walks.

while i agree with you, that a timeout should return unknown. I prefer a broader approach which would make the exit code configurable, like ex.: `./check_... -t 2:UNKNOWN` or something...

I agreed that it should be unknown but i don't think its a good idea to change that globally now. If i would approve anything in that direction, it would...

Seems like the original patch from 2003 was broken already. If somebody wants to look into it, i'd be happy to review and merge it.