Romain Tartière
Romain Tartière
I can reproduce the issue. By keeping a track of the time before we send the event and the `time_micros` of the event we found, there seems to be some...
Let's do this for now while we investigate. I am still searching where the magic of setting time_micros happen: can't find it in riemann, nor the protocol buffers gems… The...
Closing this one as @waipeng opened #371 to continue working on this using @jhunt-steds suggestion which improve readability.
Rebased and adjusted to remove references to Puppet 6 and add those for Puppet 8.
> I do not see this necessary, as the Default-Value is publicly visible anyway. My understanding is that it helps to have Puppet automatically redact secrets in diff, and that...
Why has the test suite not run against this PR? Closing and re-opening to see if it helps…
Does not seems to help. Can you please rebase your changes on top of the main branch? From your branch in your fork of the repo: ``` git fetch origin...
Can you please rebase your changes on top of the main branch (CI should be fixed)? From your working directory: ``` git fetch origin # Download the latest code we...
> Given the trivial nature of the commit, that it does not introduce new conditionals and that the current spec tests are so minimal, I think this is fine to...
It looks like that branch got somewhat messed-up for some times. I will close this PR for now, but feel free to submit a cleaned-up version if you want your...