puppet-puppetboard icon indicating copy to clipboard operation
puppet-puppetboard copied to clipboard

Published 20 hours ago • verified publisher icon voxpupuli

support for venv system packages

Open h0tw1r3 opened this issue 5 years ago • 4 comments

Adds parameter to support system packages in venv.

h0tw1r3 avatar Oct 18 '20 16:10 h0tw1r3

@h0tw1r3 Could you please rebase? That will allow this to be merged.

ghoneycutt avatar Mar 11 '21 18:03 ghoneycutt

rebased

h0tw1r3 avatar Apr 12 '21 22:04 h0tw1r3

Dear @h0tw1r3, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs? If you need any help, you can reach out to us on our IRC channel voxpupuli on Freenode or our Slack channel voxpupuli at slack.puppet.com. You can find my sourcecode at voxpupuli/vox-pupuli-tasks

vox-pupuli-tasks[bot] avatar Jun 18 '22 12:06 vox-pupuli-tasks[bot]

Dear @h0tw1r3, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

vox-pupuli-tasks[bot] avatar Jun 18 '22 13:06 vox-pupuli-tasks[bot]

rebased again

h0tw1r3 avatar Nov 25 '22 12:11 h0tw1r3

Given the trivial nature of the commit, that it does not introduce new conditionals and that the current spec tests are so minimal, I think this is fine to merge as is once it is rebased.

Same feeling here. I am removing the needs-test label. If people are not happy with this, feel free to re-add the label ;-)

smortex avatar Nov 25 '22 17:11 smortex