Samuel Moelius comments

Results 305 comments of


                                            Samuel Moelius

Incorrect suggested removal of to_string on slice

I should have a fix within a day or so.

Replace `if s.split('.').count() == 1` with `if !s.contains('.')`

In the example, `split('|')` should be `split('.')`, I think(?).

`or_fun_call` isn't always a performance lint

@hrxi Do you still have the full example? I am having trouble reproducing the behavior you described. For example, the following does not seem to trigger `or_fun_call`: ```rust enum Enum...

`or_fun_call` isn't always a performance lint

Thanks!

`or_fun_call` isn't always a performance lint

I think my question was imprecise, though. I was looking for an example that produces equivalent code even when `or_else` is used. I have little experience with this sort of...

`or_fun_call` isn't always a performance lint

Thanks again!

Slow performance (dummy mode)

> I would like to just edit `Cargo.toml` as is and as fast as possible, Could you use [toml_edit](https://docs.rs/toml_edit/0.22.7/toml_edit/)?

"error: linking with `cc` failed: exit code: 1" when "cargo build"

> it would be great to get a step in the documentation on how to reproduce crashes for debugging? Do you mean how to rerun the target on an entry...

"error: linking with `cc` failed: exit code: 1" when "cargo build"

Huh, I guess that will work in most situations. Would you like to propose a change to the documentation?

afl fails to install due `BaseDirectories` not being found in crate `xdg`

Thanks for the pointer, @Lucretiel.