Samuel Moelius

Results 106 issues of Samuel Moelius

The proposed enhancement causes `needless_borrow` to suggest removing `&` from `&e` when `&e` is an argument position requiring trait implementations, and `e` implements the required traits. Example: ``` error: the...

S-waiting-on-review

Fix #9256 changelog: none

S-waiting-on-review

In stateright, is it possible for the "environment" to have state? Or is all of the state represented in the actors? For example, could the environment have a clock that...

Addresses #3.

Consider changing these instances of `Byte` to `Integer`: https://github.com/fuzzitdev/javafuzz/blob/342735adbed192870e61dd12342c8a1f94bc0519/core/src/main/java/dev/fuzzit/javafuzz/core/Corpus.java#L322 and eliminating this cast: https://github.com/fuzzitdev/javafuzz/blob/342735adbed192870e61dd12342c8a1f94bc0519/core/src/main/java/dev/fuzzit/javafuzz/core/Corpus.java#L325 It is easy to overflow a `Byte`. Moreover, because a `Byte` is signed, an overflow can...

The `DayOfWeek` implementation expects 1-7 to represent Sun-Sat: https://github.com/cloudflare/saffron/blob/bb34024be42c735a4f48e18b9eafc3aac455e9c6/saffron/src/parse.rs#L338-L352 But many Cron sources (e.g., [this one](https://www.ibm.com/docs/en/db2/11.5?topic=task-unix-cron-format)) say that 1-7 should represent Mon-Sun, and that 0 should be an additional representation...

This PR does the following: * Moves some code from `redundant_clone` into a new `clippy_utils` module called `mir`, and wraps that code in a function called `dropped_without_further_use`. * Relaxes the...

S-waiting-on-review

I was going to suggest that we close #18 in light of #184, but it turns out that PR is only a partial solution. It catches cases like this: ```rust...

I run `markdown-link-check` in CI, and for several weeks, I've been seeing output like this: ``` 137 links checked. [✖] https://github.com/trailofbits/dylint/commit/28f3691221bc22047b9bc6d7fcefa72b038adc10 → Status: 500 ERROR: 1 dead links found! ```...