Samuel Moelius
Samuel Moelius
The most recent push squashes all of the commits except for the "Fix adjacent code" ones. The current "Fix adjacent code" commit is the result of rerunning the lint. Sadly,...
@BusyJay With your example, I see: ``` warning: the borrowed expression implements the required traits --> src/main.rs:13:14 | 13 | a.extend(&[]); // vs a.extend([]); | ^^^ help: change this to:...
No problem at all. Something like `S.push(&0)` would be ignored. There is a condition that the changed argument's type parameter not appear elsewhere in the function signature. In this case,...
However, you caused me to realize I was incorrectly assuming the argument type was a type parameter. I have corrected the error and added a relevant test.
Thanks, @mikerite!
I think the most recent push addresses all of the review comments up to this point, and the crash. Please let me know if I misunderstood anything. Regarding the "is...
> * Currently this only handles `T: SomeTrait` predicates, but `T: SomeTrait` and `U: SomeTrait` predicates also need to be handled. This requires a few steps: > > 1. Get...
I think the second round of comments are addressed.
Please let me know if I misunderstood any of your suggestions, @Jarcho.
@Jarcho How's this?