dragonhound
dragonhound
@laruh is this one ready for re-review?
> > @laruh is this one ready for re-review? > > yes please retest: enable_eth_with_tokens -> enable nft (separate req) -> update nft rpc > > enable_eth_with_tokens with nft params...
I've tested to trigger a launch fails, which returned `exit code 1: InvalidParams` in both wasm and cli for the following cases (cli logs for reference): - `08 10:39:37, mm2:315]...
> Was this using mm2_main from kdf as a lib or from starting the binary? it was from binary. I'll setup to retest this as lib
I encountered https://repoprompt.com/ earlier today which might be worth a look
> I've fixed the `core_DEV` pubkeys; the keys for the mainnet and 3p nodes were mistakenly swapped. After my last commit, they are now correct. Additionally, we need to change...
This ticker name update will need to start in KDF. We can create a branch in coins repo with renaming applied for testing.
I've not been able to get a swap completed to test this, possibly due to the errors seen in logs below: ``` 10 06:47:50, mm2_main::rpc::dispatcher:125] ERROR RPC error response: z_coin:700]...
Are any docs updates required for this PR? For testing, should I simply attempt swaps with each of the script types as the only utxos in wallet?
> cc/ @smk762 I already tested this manually btw. you can skip this if you want. Are there any related docs updates needed?