Sean Mackesey

Results 172 comments of Sean Mackesey

Current dependencies on/for this PR: * **#19667** * **#19765** * **#19898** * **#19879** 👈 * **#19920** * **#19916** * `master` This [stack of pull requests](https://stacking.dev/?utm_source=stack-comment) is managed by [Graphite](https://app.graphite.dev/github/pr/dagster-io/dagster/19879?utm_source=stack-comment).

>I still recommend extracting changes in python_modules/dagster/dagster/_core/definitions/sensor_definition.py into sep PR https://github.com/dagster-io/dagster/pull/19916/

This looks OK given that it's such a small change and no tests broke broke, but I'm wondering whether you tested this manually at all? Also @the4thamigo-uk, would you mind...

I believe this is fixed in this week's release, but let's let the user who opened this confirm that, and I will also check on partitioned assets. This "maximum recursion...

I had a peek at this. I confirmed that in its current state the PR produces an incorrect result on the ops root page (as flagged by @alangenfeld) for a...

cc @prha any ideas? Or is this a known issue that's been fixed in later releases?

Here's a related instance. Before: ``` tox_command_parts = filter( None, [ "tox", "-vv", # extra-verbose "-c %s " % tox_file if tox_file else None, "-e", tox_env, ], ) ``` After:...

Hmm, it no longer enters an infinite loop, but an exception is still thrown: > /Users/seanmackesey/Desktop/count_inference/lib/db/models/region.rb:288:in `' > when_started hook failed: NoMethodError: undefined method`safe_send' for #PryStackExplorer::WhenStartedHook:0x007fdc10abd378 > /Users/seanmackesey/.rvm/gems/ruby-1.9.3-p194/gems/pry-stack_explorer-0.4.8pre1/lib/pry-stack_explorer/when_started_hook.rb:10:in `block in...

cc @benpankow (seeing relevant line blame to you, feel free to suggest someone else), should this just be a bool option? That's what the description seems to suggest.

* **#20405** * **#20227** * **#20361** * **#19667** 👈 * **#20132** : 1 other dependent PR ([#20323](https://github.com/dagster-io/dagster/pull/20323) ) * **#20114** * **#20276** * **#20223** * **#20298** * `master` This stack...