Sean Mackesey

Results 172 comments of Sean Mackesey

`pyright` enforces something similar but with some tweaks-- I believe if `ruff` implements this it should follow pyright's publicity rules, which are also in a [document](https://github.com/python/typing/blob/master/docs/source/libraries.rst#library-interface-public-and-private-symbols) in the `python/typing` repo...

>Publicity rules are perhaps the work of a PR bureau, these things are often named visibility rules in this domain. Take it up with the maintainers of python/typing: https://github.com/python/typing/blob/master/docs/source/libraries.rst#library-interface-public-and-private-symbols

Thanks-- yeah I've done a lot over the past 24 hours assessing `ruff` and trying to port Dagster OSS. Almost at the finish line. Your selling point of extreme speed...

Just wondering whether this is now easily doable with all the changes in the last year to ruff. Would be a nice QOL improvement for us.

@charliermarsh Oh I didn't realize-- do you support all the isort [action comments](https://pycqa.github.io/isort/docs/configuration/action_comments.html), like `isort: split` and `isort: skip_file`?

Hmm `# isort: off` doesn't seem to be working. Ruff `0.0.160` reports import errors on the below file-- shouldn't the `# isort: off` at the top disable any `I001` error...

> I could add support for split and/or skip_file if those are impactful for you. We do use `split`. IIUC `skip_file` is the same as putting `off` at the top....

>It should work if you add # isort: on to the bottom (which should probably be considered a bug). Definitiely a bug going by the `isort` docs for `off`: >Turns...

>What if we support [ESLint-like on/off comments](https://eslint.org/docs/latest/user-guide/configuring/rules#disabling-rules)? Sounds good to me! In general I'd take as much inspiration from eslint as possible, it's a lot better than the offerings of...

Is this on the radar for anytime soon? BTW `ruff` has been fantastic for us since we adopted it at Dagster.