dagster icon indicating copy to clipboard operation
dagster copied to clipboard

Published 20 hours ago • verified publisher icon dagster-io

stale_assets_only doesnt support partitions (#18921)

Open the4thamigo-uk opened this issue 1 year ago • 6 comments

Summary & Motivation

How I Tested These Changes

the4thamigo-uk avatar Dec 28 '23 13:12 the4thamigo-uk

Hey @the4thamigo-uk - thanks for you patience. I pinged @smackesey about this.

sryza avatar Jan 16 '24 22:01 sryza

No review yet?

the4thamigo-uk avatar Feb 09 '24 14:02 the4thamigo-uk

Is there more context here? Why is the motivation behind this change? Is there an issue?

schrockn avatar Feb 09 '24 17:02 schrockn

Hi @schrockn, the scenario is here https://github.com/dagster-io/dagster/issues/18921.

the4thamigo-uk avatar Feb 12 '24 14:02 the4thamigo-uk

This looks OK given that it's such a small change and no tests broke broke, but I'm wondering whether you tested this manually at all?

Also @the4thamigo-uk, would you mind linking that PR and adding a sentence of explanation in the summary?

smackesey avatar Feb 12 '24 16:02 smackesey

I did manually test, but I suppose I should write a unit test for this, I will try to find the time. I just wanted feedback on whether there was any obvious understanding I was missing out on here.

the4thamigo-uk avatar Feb 14 '24 14:02 the4thamigo-uk