Krystian Chmura comments

Results 27 comments of


                                            Krystian Chmura

feat: make placeholder configurable regardless of dialect

Could you describe why? Is this some unusual db engine?

feat: make placeholder configurable regardless of dialect

please rename the commit message to https://www.conventionalcommits.org/en/v1.0.0/#summary , so maybe `feat: make placeholder configurable regardless of dialect`

feat: make placeholder configurable regardless of dialect

@peakle added comments. Please ping me, when you address it (or any other doubts), so i can review it quicker

`Load()` calculate hash of every table at the end and I don't know why

Oh I see, it make sense for subsequent `Load` calls. Do you think it make sense to make some flag to disable this behavior? In my case I use `Load`...

`Load()` calculate hash of every table at the end and I don't know why

@andreynering this flag control that piece of code: https://github.com/go-testfixtures/testfixtures/blob/b1fe75b2f31f9af027da52787e7c2892f9703c47/testfixtures.go#L420-L430 where I want to skip this: https://github.com/go-testfixtures/testfixtures/blob/b1fe75b2f31f9af027da52787e7c2892f9703c47/testfixtures.go#L460 Reason: In my code I use this library in such a way: ```golang fixtures,...

Remove driver related bloat from `go.mod`

@AlphaNecron i removed all underscore imports from the lib. The total trim (so also `go.mod` file) is planned for the next release

docs: add warning about importance of option order

@Rabsztok IMO it makes more sense to fix this behavior instead of documenting it Let me check, if it is possible. I will ping you