Krystian Chmura
Krystian Chmura
@UpcraftLP could you review it?
> Looking great here, however, instead of validating the current (wrong) behavior, please change the tests to validate the desired behavior as indicated, so that the tests fail and can...
> Having failing tests is fine, I would merge the PR regardless. If it is not blocking anything (like docker build and push, i don't know) then why not
`npm run start` instead of `npm run start:dev`. You can deduce it by looking at the JS codebase
@mjferrante83 @fatmagic my setup is super easy This repo: ``` docker-compose -f docker-compose.Development.yml up -d db go run ./rogueserver.go ``` and the game ``` npm install npm run start ```...
@mjferrante83 two things: * you don't need to check the `server -> db` connection. On start the `server` tries to apply database setup so you would see any problem in...
@ccoVeille thanks a lot. I will check it
> Running go mod tidy on some of the dirs (like dbtests/) introduce small changes due to package updates. Fixed > We might need to update the Dependabot config to...
Perhaps that value is implicitly casted to a `time.Time` in this code https://github.com/go-testfixtures/testfixtures/blob/98baced6f3905ea319026663731723f8612903d2/time.go#L8-L43 Removing this pattern would help, but I am worried about breaking a backward compatibility to this feature
From my experience the indexed version is rarely useful in comparison to `func (item T)`. The latter allows you to use the existing function conveniently ```golang lo.Map(foo, bar) // vs...