testfixtures icon indicating copy to clipboard operation
testfixtures copied to clipboard
verified publisher icon go-testfixtures

feat: make placeholder configurable regardless of dialect

Open peakle opened this issue 7 months ago • 5 comments

peakle avatar May 30 '25 14:05 peakle

Could you describe why? Is this some unusual db engine?

slsyy avatar May 30 '25 18:05 slsyy

please rename the commit message to https://www.conventionalcommits.org/en/v1.0.0/#summary , so maybe feat: make placeholder configurable regardless of dialect

slsyy avatar May 30 '25 18:05 slsyy

Could you describe why? Is this some unusual db engine?

It's clickhouse and my driver lib supports only question placeholder and on other hand test fixtures support only dollar

peakle avatar May 31 '25 05:05 peakle

@slsyy any other comments? I'm really looking forward to this PR because i should use "replace" for two libs in go.mod without this changes :/

peakle avatar Jun 04 '25 16:06 peakle

@peakle added comments. Please ping me, when you address it (or any other doubts), so i can review it quicker

slsyy avatar Jun 04 '25 16:06 slsyy