Sam Lantinga

@Kethen, the convention is to add copyright holders to the license at the top, e.g. https://github.com/libsdl-org/SDL/blob/23410debf7ad2d05d4662ed38af110e43b2e3a14/src/camera/pipewire/SDL_camera_pipewire.c#L3-L4

> Hello @slouken, currently ported functions are annotated this way > > https://github.com/libsdl-org/SDL/blob/54f4837a77374e3b4e1522e1a5460a8513be263d/src/haptic/hidapi/SDL_hidapihaptic_lg4ff.c#L1140-L1148 > > What would be appropriate to add to the header of files in this PR (and...

> > @Kethen, the convention is to add copyright holders to the license at the top, e.g. > > https://github.com/libsdl-org/SDL/blob/23410debf7ad2d05d4662ed38af110e43b2e3a14/src/camera/pipewire/SDL_camera_pipewire.c#L3-L4 > > This is what I expected. In my very...

So this is out of scope for SDL2, but I'll leave a reference to https://github.com/libsdl-org/SDL/pull/11598 here for tracking legal permissions and I plan to accept that for 3.4.0. Thanks!

I still want to compile out the validity checks entirely if someone builds with a flag to do so, and possibly disable parameter validation entirely, so I'm not sure whether...

> I think the least invasive option would be to compare sdl's mouse state to what macos says (`CGEventSourceButtonState`) and send the missing mouse up event before the next button...

This is potentially complicated by having event sources in the future and really wanting a mouse press canceled event in this case, but this will take care of the mouse...

I haven't tested it, but this seems reasonable to me. @icculus, thoughts?

> Is there something I can do to make reviewing easier? Yes, can you fix the conflicts? Also, there are a number of issues with your PR. First, you're not...

Merged, thanks!