Sebastien Loriot

Results 671 comments of Sebastien Loriot

There are still issues in pmp-library in the generated`pmpTargets.cmake`: The following is generated: ``` set_target_properties(pmp PROPERTIES INTERFACE_COMPILE_OPTIONS "-std=c++11" INTERFACE_INCLUDE_DIRECTORIES "/home/sloriot/projects/pmp-library.git/src/pmp/../" INTERFACE_LINK_LIBRARIES "OpenMP::OpenMP_CXX" ) ``` while something like that should be...

Code is in [this branch](https://github.com/CGAL/cgal-public-dev/tree/gsoc2024-mollification-iomar)

Successfully tested in CGAL-6.1-Ic-189

Successfully tested in CGAL-6.1-Ic-208

Locally building the polyhedron demo I got: ``` STL_Extension/include/CGAL/callback.h:34:0: warning: "CGAL_CALLBACK" redefined # define CGAL_CALLBACK(f, p1) ^ STL_Extension/include/CGAL/callback.h:33:0: note: this is the location of the previous definition # define CGAL_CALLBACK(f)...

The patch is still not working: ``` /home/sloriot/CGAL/git/integration/STL_Extension/include/CGAL/callback.h:34:0: warning: "CGAL_CALLBACK" redefined # define CGAL_CALLBACK(f, p1) ^ /home/sloriot/CGAL/git/integration/STL_Extension/include/CGAL/callback.h:33:0: note: this is the location of the previous definition # define CGAL_CALLBACK(f) ^...

TODO: Once all tests pass, add specialization of the construction wrapper to use approx input when possible (to avoid non needed conversion to interval).

@lrineau I'm not sure about the fix. `Boost_DIR` shall point to where `BoostConfig.cmake` is located but `BOOST_ROOT` should point to the root of the installation, isn't it?

That's my point: BOOT_ROOT installation prefix while config mode should be using `Boost_DIR`.