Sebastien Loriot comments

Results 671 comments of


                                            Sebastien Loriot

Using std::optional for Property_container::get<T>

The API change is possible thanks to `std::optional` that is introduced in CGAL APIs with CGAL 6.0, and Orthtree is already using it for its dynamic property system.

Using std::optional for Property_container::get<T>

Successfully tested in CGAL-6.0-Ic-245

Core: Use Expr::is_zero() of AST

Successfully tested in CGA-6.0-Ic-173

Core: Use Expr::is_zero() of AST

Successfully tested in CGAL-6.0-Ic-192

Tet remeshing - add sizing field

``` /mnt/testsuite/include/CGAL/Tetrahedral_remeshing/internal/tetrahedral_adaptive_remeshing_impl.h:366:9: warning: misleading indentation; statement is not part of the previous 'for' [-Wmisleading-indentation] 366 | if (input_is_c3t3() && m_c3t3.is_in_complex(cit)) | ^ /mnt/testsuite/include/CGAL/Tetrahedral_remeshing/internal/tetrahedral_adaptive_remeshing_impl.h:361:7: note: previous statement is here 361 |...

Tet remeshing - add sizing field

There are also some runtime errors and I notice that there are a lot of time-out in CGAL 6.0-Ic-206

Tet remeshing - add sizing field

Successfully tested in CGAL-6.0-Ic-237 (only two timeout, well done!)

CGAL::IO::Internal::read_OBJ(): allow arbitrary whitespace in "f" lines

Successfully tested in CGAL-6.0-Ic-116

CGAL::IO::Internal::read_OBJ(): allow arbitrary whitespace in "f" lines

@MaelRL what TODO do you have in mind?

CGAL::IO::Internal::read_OBJ(): allow arbitrary whitespace in "f" lines

@MaelRL ping!!!!