Tet remeshing - add sizing field
Summary of Changes
This PR adds a sizing field as input for CGAL::tetrahedral_isotropic_remeshing(), that can be passed as second parameter, instead of target_edge_length.
Release Management
- Affected package(s): Tetrahedral_remeshing
- Issue solved : #6056
- Small Feature : wiki, pre-approved by @lrineau, 20024/04/08
- Link to compiled documentation doc
- License and copyright ownership: unchanged
Todo
- [x] ~~use
Mesh_sizing_fieldlike the optimizers do (adapt it to be aMeshDomainField_3) and find an API for it~~ - [x] write a new adaptive sizing field that keeps the same mesh density after remeshing
- [x] options in the demo
- [x] example
- [x] documentation (depends on Mesh_3 for
MeshDomainField_3) - [x] small feature
- [ ] check size (for @sloriot)
At this point, remeshing can use the same sizing field as the one given to Mesh_3 for cell_size or facet_size, and it is used in a naive manner.
It looks like this
/build:v0
There was an error while building the doc:
/home/runner/work/cgal/cgal/build_doc/doc_tags/Polygon_mesh_processing.tag:2523: warning: Duplicate anchor fig__uniform_and_adaptive found
/home/runner/work/cgal/cgal/build_doc/doc_tags/Polygon_mesh_processing.tag:2523: warning: Duplicate anchor fig__uniform_and_adaptive found
/home/runner/work/cgal/cgal/Tetrahedral_remeshing/doc/Tetrahedral_remeshing/examples.txt:10: warning: Example Tetrahedral_remeshing/mesh_and_remesh_with_sizing.cpp was already documented. Ignoring documentation found here.
/home/runner/work/cgal/cgal/Tetrahedral_remeshing/doc/Tetrahedral_remeshing/examples.txt:11: warning: Example Tetrahedral_remeshing/mesh_and_remesh_with_adaptive_sizing.cpp was already documented. Ignoring documentation found here.
/home/runner/work/cgal/cgal/Tetrahedral_remeshing/doc/Tetrahedral_remeshing/Tetrahedral_remeshing.txt:64: warning: Found unknown command '\secTetRemeshing'
https://github.com/CGAL/cgal/actions/runs/7061477556
/force-build:v0
The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/7830/v0/Manual/index.html
/build:v1
The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/7830/v1/Manual/index.html
/mnt/testsuite/include/CGAL/Tetrahedral_remeshing/internal/tetrahedral_adaptive_remeshing_impl.h:366:9: warning: misleading indentation; statement is not part of the previous 'for' [-Wmisleading-indentation]
366 | if (input_is_c3t3() && m_c3t3.is_in_complex(cit))
| ^
/mnt/testsuite/include/CGAL/Tetrahedral_remeshing/internal/tetrahedral_adaptive_remeshing_impl.h:361:7: note: previous statement is here
361 | for (Vertex_handle vi : tr().vertices(cit))
| ^
There are also some runtime errors and I notice that there are a lot of time-out in CGAL 6.0-Ic-206
/force-build:v1
The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/7830/v1/Manual/index.html
/force-build:v1
The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/7830/v1/Manual/index.html
/force-build:v1
There was an error while building the doc:
/home/runner/work/cgal/cgal/BGL/doc/BGL/PackageDescription.txt:682: warning: explicit link request to 'is_tetrahedron()' could not be resolved
https://github.com/CGAL/cgal/actions/runs/8600663567
change the namespace of create_adaptive... to CGAL:: (and add it to the ref manual entry page)
/build:v2
There was an error while building the doc:
/home/runner/work/cgal/cgal/BGL/doc/BGL/PackageDescription.txt:682: warning: explicit link request to 'is_tetrahedron()' could not be resolved
https://github.com/CGAL/cgal/actions/runs/8614462438
/build:v2
The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/7830/v2/Manual/index.html
/force-build:v2
The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/7830/v2/Manual/index.html
/force-build:v2
The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/7830/v2/Manual/index.html
The testsuite passes on my machine, but it Debug mode it is still far beyond the timeout limit (and far below in Release mode)
The full ctest of examples and tests for the Tetrahedral_remeshing package passes on my machine, far below the 1200 sec timeout. Ready to be tested :-)
Successfully tested in CGAL-6.0-Ic-237 (only two timeout, well done!)
This pull-request was previously marked with the label Tested, but has been modified with new commits. That label has been removed.
/force-build:v2
There was an error while building the doc:
/home/runner/work/cgal/cgal/Tetrahedral_remeshing/doc/Tetrahedral_remeshing/Tetrahedral_remeshing.txt:71: warning: explicit link request to 'params' could not be resolved
https://github.com/CGAL/cgal/actions/runs/9029612547