cgal icon indicating copy to clipboard operation
cgal copied to clipboard

Tet remeshing - add sizing field

Open janetournois opened this issue 2 years ago • 26 comments

Summary of Changes

This PR adds a sizing field as input for CGAL::tetrahedral_isotropic_remeshing(), that can be passed as second parameter, instead of target_edge_length.

Release Management

  • Affected package(s): Tetrahedral_remeshing
  • Issue solved : #6056
  • Small Feature : wiki, pre-approved by @lrineau, 20024/04/08
  • Link to compiled documentation doc
  • License and copyright ownership: unchanged

Todo

  • [x] ~~use Mesh_sizing_field like the optimizers do (adapt it to be a MeshDomainField_3) and find an API for it~~
  • [x] write a new adaptive sizing field that keeps the same mesh density after remeshing
  • [x] options in the demo
  • [x] example
  • [x] documentation (depends on Mesh_3 for MeshDomainField_3)
  • [x] small feature
  • [ ] check size (for @sloriot)

janetournois avatar Oct 26 '23 10:10 janetournois

At this point, remeshing can use the same sizing field as the one given to Mesh_3 for cell_size or facet_size, and it is used in a naive manner. It looks like this image

janetournois avatar Oct 26 '23 12:10 janetournois

/build:v0

janetournois avatar Dec 01 '23 14:12 janetournois

There was an error while building the doc:

/home/runner/work/cgal/cgal/build_doc/doc_tags/Polygon_mesh_processing.tag:2523: warning: Duplicate anchor fig__uniform_and_adaptive found
/home/runner/work/cgal/cgal/build_doc/doc_tags/Polygon_mesh_processing.tag:2523: warning: Duplicate anchor fig__uniform_and_adaptive found
/home/runner/work/cgal/cgal/Tetrahedral_remeshing/doc/Tetrahedral_remeshing/examples.txt:10: warning: Example Tetrahedral_remeshing/mesh_and_remesh_with_sizing.cpp was already documented. Ignoring documentation found here.
/home/runner/work/cgal/cgal/Tetrahedral_remeshing/doc/Tetrahedral_remeshing/examples.txt:11: warning: Example Tetrahedral_remeshing/mesh_and_remesh_with_adaptive_sizing.cpp was already documented. Ignoring documentation found here.
/home/runner/work/cgal/cgal/Tetrahedral_remeshing/doc/Tetrahedral_remeshing/Tetrahedral_remeshing.txt:64: warning: Found unknown command '\secTetRemeshing'

https://github.com/CGAL/cgal/actions/runs/7061477556

github-actions[bot] avatar Dec 01 '23 14:12 github-actions[bot]

/force-build:v0

janetournois avatar Dec 01 '23 15:12 janetournois

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/7830/v0/Manual/index.html

github-actions[bot] avatar Dec 01 '23 15:12 github-actions[bot]

/build:v1

janetournois avatar Mar 28 '24 16:03 janetournois

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/7830/v1/Manual/index.html

github-actions[bot] avatar Mar 28 '24 16:03 github-actions[bot]

/mnt/testsuite/include/CGAL/Tetrahedral_remeshing/internal/tetrahedral_adaptive_remeshing_impl.h:366:9: warning: misleading indentation; statement is not part of the previous 'for' [-Wmisleading-indentation]
  366 |         if (input_is_c3t3() && m_c3t3.is_in_complex(cit))
      |         ^
/mnt/testsuite/include/CGAL/Tetrahedral_remeshing/internal/tetrahedral_adaptive_remeshing_impl.h:361:7: note: previous statement is here
  361 |       for (Vertex_handle vi : tr().vertices(cit))
      |       ^

sloriot avatar Apr 02 '24 09:04 sloriot

There are also some runtime errors and I notice that there are a lot of time-out in CGAL 6.0-Ic-206

sloriot avatar Apr 02 '24 09:04 sloriot

/force-build:v1

afabri avatar Apr 03 '24 14:04 afabri

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/7830/v1/Manual/index.html

github-actions[bot] avatar Apr 03 '24 14:04 github-actions[bot]

/force-build:v1

janetournois avatar Apr 04 '24 07:04 janetournois

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/7830/v1/Manual/index.html

github-actions[bot] avatar Apr 04 '24 08:04 github-actions[bot]

/force-build:v1

lrineau avatar Apr 08 '24 13:04 lrineau

There was an error while building the doc:

/home/runner/work/cgal/cgal/BGL/doc/BGL/PackageDescription.txt:682: warning: explicit link request to 'is_tetrahedron()' could not be resolved

https://github.com/CGAL/cgal/actions/runs/8600663567

github-actions[bot] avatar Apr 08 '24 13:04 github-actions[bot]

change the namespace of create_adaptive... to CGAL:: (and add it to the ref manual entry page)

lrineau avatar Apr 08 '24 15:04 lrineau

/build:v2

janetournois avatar Apr 09 '24 10:04 janetournois

There was an error while building the doc:

/home/runner/work/cgal/cgal/BGL/doc/BGL/PackageDescription.txt:682: warning: explicit link request to 'is_tetrahedron()' could not be resolved

https://github.com/CGAL/cgal/actions/runs/8614462438

github-actions[bot] avatar Apr 09 '24 10:04 github-actions[bot]

/build:v2

janetournois avatar Apr 09 '24 12:04 janetournois

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/7830/v2/Manual/index.html

github-actions[bot] avatar Apr 09 '24 12:04 github-actions[bot]

/force-build:v2

janetournois avatar Apr 09 '24 13:04 janetournois

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/7830/v2/Manual/index.html

github-actions[bot] avatar Apr 09 '24 13:04 github-actions[bot]

/force-build:v2

janetournois avatar Apr 09 '24 13:04 janetournois

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/7830/v2/Manual/index.html

github-actions[bot] avatar Apr 09 '24 13:04 github-actions[bot]

The testsuite passes on my machine, but it Debug mode it is still far beyond the timeout limit (and far below in Release mode)

janetournois avatar May 02 '24 07:05 janetournois

The full ctest of examples and tests for the Tetrahedral_remeshing package passes on my machine, far below the 1200 sec timeout. Ready to be tested :-)

janetournois avatar May 06 '24 18:05 janetournois

Successfully tested in CGAL-6.0-Ic-237 (only two timeout, well done!)

sloriot avatar May 10 '24 06:05 sloriot

This pull-request was previously marked with the label Tested, but has been modified with new commits. That label has been removed.

github-actions[bot] avatar May 10 '24 08:05 github-actions[bot]

/force-build:v2

janetournois avatar May 10 '24 08:05 janetournois

There was an error while building the doc:

/home/runner/work/cgal/cgal/Tetrahedral_remeshing/doc/Tetrahedral_remeshing/Tetrahedral_remeshing.txt:71: warning: explicit link request to 'params' could not be resolved

https://github.com/CGAL/cgal/actions/runs/9029612547

github-actions[bot] avatar May 10 '24 08:05 github-actions[bot]