Shane Loretz

Results 48 comments of Shane Loretz

Maybe we could copy the behavior of `asyncio` by adding an api to [set an exception handler on the executor](https://docs.python.org/3/library/asyncio-eventloop.html#asyncio.loop.set_exception_handler), where [the default is to log and move on](https://github.com/python/cpython/blob/f366e215044e348659df814c27bf70e78907df21/Lib/asyncio/base_events.py#L1800-L1814)?

[Holding for Humble sync](https://discourse.ros.org/t/preparing-for-humble-sync-2024-04-18/37216)

[Holding for Humble sync](https://discourse.ros.org/t/preparing-for-humble-sync-2024-04-18/37216)

This is an interesting one. On the ROS side `resource_retriever` [can handle `package://` URIs](https://github.com/ros/resource_retriever/blob/92ba434080f35983926c6a3ab905b7318029b235/resource_retriever/src/retriever.cpp#L100), but by default `SDFormat` only supports `model://`. `libsdformat` is able to parse URDF, and during that...

Some test failures seem unrelated to the PR. Maybe a rebase will fix it? ``` /Volumes/BuildData/tmpfs/altsrc/github/grpc/workspace_c++_macos_dbg_native/test/core/end2end/fuzzers/server_fuzzer_chaotic_good.cc:18:10: fatal error: 'src/libfuzzer/libfuzzer_macro.h' file not found #include "src/libfuzzer/libfuzzer_macro.h" ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated. ```

Test results look much better after rebasing! I rebased again and added two commits fixing the copyright and buildifier test failures. The PHP Mac OS test failures seem unrelated though....

Issues in last run of CI. I'm struggling to find connections with the failing tests and this PR. Is green CI expected on this repo? ## promis_based_client_call.exe not created on...

The PHP MacOS tests are failing on another PR that only changes a markdown file, so I assume no need to worry about those. https://github.com/grpc/grpc/pull/35772