Krzysztof Słonka

DCO and build are failing - please make sure that they are passing. Also did you do it according to the docs provided here: https://github.com/envoyproxy/java-control-plane/#bring-api-up-to-date-with-data-plane-api ?

Do not merge until our environment is ready.

@lukidzi do you remember the requirement here? do we need wrapper in a certain version? EDITED: yes, we need newest wrapper, then this change, then we can clean up wrapper.

Some initial work has been done here: https://github.com/allegro/envoy-control/compare/run-tests-in-parallel-3?expand=1 The main problem seems to be that CircleCI expects a list of test classes to assign each worker a set of them,...

Example here: https://github.com/all-of-us/workbench/commit/47fa824621aabfa8c05a6c9637f28776518c6f7b#diff-78a8a19706dbd2a4425dd72bdab0502ed7a2cef16365ab7030a5a0588927bf47R322

This is supposed to be support for services registered as domains in Consul (not ips).

@danielkwinsor we know that we can use STRICT_DNS and LOGICAL_DNS but AFAIK there is no way to **mix** both EDS and DNS clusters under the same name. If you need...

It would require a change to add the token here: https://github.com/allegro/consul-recipes/blob/f42b2367f04fdd7646877889a61e4549aa50adcd/src/main/java/pl/allegro/tech/discovery/consul/recipes/watch/ConsulWatcher.java#L37 and then use it here: https://github.com/allegro/envoy-control/blob/43d51f58861c0b7ece057c807a6f8c1002346e4b/envoy-control-runner/src/main/kotlin/pl/allegro/tech/servicemesh/envoycontrol/infrastructure/consul/ConsulWatcherConfig.kt#L52 and pass it somewhere in the configuration. The change should not be complicated...

This PR is 1 year old 🎂 🥳

This issue is needed to be able to implement this: https://github.com/kumahq/kuma/issues/2483 - any updates on development here?