java-control-plane icon indicating copy to clipboard operation
java-control-plane copied to clipboard

Published 20 hours ago • verified publisher icon envoyproxy

Envoy proto upgrade

Open bartebor opened this issue 5 years ago • 8 comments

Hello,

it looks like java-control-plane fell behind envoy api updates.

I have a need of some v1.14 features, so I updated protos to v1.14.4. It was quite straightforward, but it means I have to maintain my own build of the library. I can make a PR with those changes.

Update to v1.15.0 (still supporting v2) will be more involving as there are much more changes to address in repository versions; I could look into that too if there was a demand.

Are there any plans on updating protos with each envoy release?

bartebor avatar Jul 31 '20 08:07 bartebor

I'd like to know this as well. Do we need to maintain it ourselves or can we depend on this repo to have periodic updates? Thanks.

senthilkumarkj avatar Dec 01 '20 03:12 senthilkumarkj

@senthilkumarkj protobuf update is here https://github.com/envoyproxy/java-control-plane/pull/155.

slonka avatar Dec 02 '20 12:12 slonka

Are there any plans on updating protos with each envoy release?

Ideally we would like to trigger this update when new Envoy version is released. If anyone is interested in automating it, then go for it.

slonka avatar Dec 02 '20 12:12 slonka

This issue was raised more than an year back and there have been a few Envoy releases post that. Still proto definitions are not updated.

techpavan avatar Aug 04 '21 13:08 techpavan

@techpavan as mentioned in my previous comment feel free to automate this task. There are a couple of ideas floating around on how to do this. One of them is some sort of a hook that would automatically trigger the bash script (that is located in tools folder) and create a PR. We can talk details if you're interested.

slonka avatar Aug 04 '21 16:08 slonka

Hi @slonka Not sure if I would make time for automation in an unfamiliar territory. But for now, I have shared PR for updating the proto files. I just tested the build [mvn clean install] to be successful. Please feel free to add / share any other changes if needed.

techpavan avatar Aug 09 '21 09:08 techpavan

DCO and build are failing - please make sure that they are passing. Also did you do it according to the docs provided here: https://github.com/envoyproxy/java-control-plane/#bring-api-up-to-date-with-data-plane-api ?

slonka avatar Aug 09 '21 09:08 slonka

Haven't followed that guide. Just manually pulled the latest ones. Will update and share.

techpavan avatar Aug 09 '21 10:08 techpavan