Sam Levenick
Sam Levenick
Per https://github.com/GoogleCloudPlatform/magic-modules/pull/7205#issuecomment-1413890976 I believe this is a breaking change and we can't do it in a minor release
We just won't be able to merge this change until a major release is imminent, which may not be for several months
Alternatively as noted in https://github.com/hashicorp/terraform-provider-google/issues/13430#issuecomment-1412645376 it may be possible to handle reordering on our side without changing the type to a TypeSet, which would allow the fix to be merged...
@kautikdk please review, I'll do a pass after you give approval
It still sees the commit as belonging to another contributor
> @slevenick FYI - would you have any concern about us moving forward with this PR? I would just make sure tests pass after my PR from last week changed...
Just approved tests, but I think this will fail all the existing tests as they don't specify internal_ip_only = false
Hey @mleonhard I'm unable to find any REST APIs for configuring this resource on Firebase. Are you aware of such APIs? For example here is a link to the documentation...
Yep that looks reasonable. I must have been looking in a different part of firebase.
How do you currently set the APNS auth key? When you say manual what do you mean by that? I don't see the APNS auth key present in that REST...