magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

Change the type of internal_ips and external_ips to Set instead of List.

Open askubis opened this issue 1 year ago • 13 comments

Previous bevahiour was causing flaking tests, as List enforces an order, whereas MIG API does not.

fixes https://github.com/hashicorp/terraform-provider-google/issues/13430

If this PR is for Terraform, I acknowledge that I have:

  • [X] Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • [X] Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • [X] Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • [X] Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • [X] Read the Release Notes Guide before writing my release note below.
compute: Fixed problem with ordering in stateful tests of InstanceGroupManager and RegionInstanceGroupManager

askubis avatar Feb 02 '23 14:02 askubis