Sylwester Arabas

icon indicating a website link https://slayoo.github.io/ icon indicating an email [email protected]

icon company agh.edu.pl icon location Kraków, Poland icon location researching clouds in the cloud

Results 518 comments of Sylwester Arabas

covering AeroMode instantiation with sampled mode type in unit tests (both in test_aero_mode and test_aero_dist)

@jcurtis2, the issue with the new `test_sampled` test was that ```python "size_dist": [ {"num_conc": num_concs}, {"diam": [1, 2, 3, 4]}, ], ``` and ```python "size_dist": [ {"diam": [1, 2, 3,...

covering AeroMode instantiation with sampled mode type in unit tests (both in test_aero_mode and test_aero_dist)

hmm... let's then first try adding a test that would check if the `diam`s are correctly being stored...

covering AeroMode instantiation with sampled mode type in unit tests (both in test_aero_mode and test_aero_dist)

Thanks Jeff!

covering AeroMode instantiation with sampled mode type in unit tests (both in test_aero_mode and test_aero_dist)

BTW, do we have any mean of testing it from Python at this point? (indirectly by sampling from the dist?)

covering AeroMode instantiation with sampled mode type in unit tests (both in test_aero_mode and test_aero_dist)

Thanks @jcurtis2 Looks good to me, please confirm if OK to merge (and release)?

bump SUNDIALS submodule to v6.7.0 (blocked by CAMP not supporting SUNDIALS >= 6)

this fails with: ``` /home/runner/work/PyPartMC/PyPartMC/gitmodules/camp/src/camp_solver.c:145:11: error: too few arguments to function ‘N_VNew_Serial’ 145 | sd->y = N_VNew_Serial(n_dep_var * n_cells); | ^~~~~~~~~~~~~ ``` We need to update SUNDIALS calls within CAMP...

Enable nucleation

https://github.com/compdyn/partmc/pull/188

rename gimmicks to something like json_resource?

see https://github.com/open-atmos/PyPartMC/issues/233#issuecomment-1826466742

Fractal dimension is hardcoded to be spherical

https://github.com/compdyn/partmc/pull/188

report AeroMode::ctor segfault case upstream to pybind11

there is a test depicting it in the test suite: https://github.com/open-atmos/PyPartMC/blob/8630eb9a6578a65ae7a4f1d7d90869c61ec69e7d/tests/test_aero_mode.py#L277-L286