Alex Chi Z. comments

Results 309 comments of


Alex Chi Z.

feat: added the steps to run flink bench via pipeline

> Currently buildkite is only free for open source projects Hope this is not an abuse of Buildkite open-source program 🤣 I'm fine with that.

feat(ctl): list pinned hummock versions and snapshots

LGTM. Let's merge?

Eliminate hardcoded values

To contributors: one example of resolving this issue is: https://github.com/risingwavelabs/risingwave/pull/5361. It's just about moving variables to the config file. Welcome to have a try!

Suggestion: Give students Kaitai Struct grammar for viewing binary page data as structured object trees

Looks pretty cool to me! I’ll look into possibilities of integrating this tool.

docs: fix license headers and file identifications

Unluckily, the only `.sh` file in this repo is `build_support/packages.sh`. Do you mean some tools outside of this repo?

binder: detect type casting issues

also we will handle thing like `insert null` in this issue.

planner: plan create index

postponed to the next year as personally we don't want students to implement too many executors for p3

feat(test): add sqllogictest

The query grammar: ``` query rowsort select v2, v2 + 1, sum(v1) from t group by v2 + 1, v2 ---- 1 2 3 3 4 5 2 3 7...

feat(test): add sqllogictest

Usage: ``` ./bin/bustub-sqllogictest ../test/sql/intro.slt ```

[Proposal]: Add LLVM Thread Safety Analyzer annotations for better developer experience + safety

That's great!!! This is one of the most functionality that I've missed from the Rust programming language when I started to work on the BusTub project.