risingwave icon indicating copy to clipboard operation
risingwave copied to clipboard

feat: added the steps to run flink bench via pipeline

Open sumittal opened this issue 3 years ago • 1 comments

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

Added the flink benchmark automation via pipeline

There is pre-existing AMI created to run the EC2 instance and run the flink benchmark.

  • Added a new pipeline in buildkite called flink-bench to run the benchmark
  • Added the shell scripts to represent the steps to run the flink benchmark

Checklist

  • [x] I have tested the shell script being used to run the benchmark

Documentation

Below are the steps: https://github.com/risingwavelabs/flink-bench/tree/main/standalone

Release note

Please create a release note for your changes. In the release note, focus on the impact on users, and mention the environment or conditions where the impact may occur.

Refer to a related PR or issue link (optional)

sumittal avatar Sep 21 '22 08:09 sumittal

Codecov Report

Merging #5471 (b4f4152) into main (5587547) will increase coverage by 0.00%. The diff coverage is 59.72%.

:exclamation: Current head b4f4152 differs from pull request most recent head 042f898. Consider uploading reports for the commit 042f898 to get more accurate results

@@           Coverage Diff            @@
##             main    #5471    +/-   ##
========================================
  Coverage   74.26%   74.26%            
========================================
  Files         906      907     +1     
  Lines      142634   143227   +593     
========================================
+ Hits       105925   106369   +444     
- Misses      36709    36858   +149     
Flag Coverage Δ
rust 74.26% <59.72%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/batch/src/executor/row_seq_scan.rs 17.59% <0.00%> (+0.08%) :arrow_up:
src/ctl/src/cmd_impl/hummock/list_kv.rs 0.00% <0.00%> (ø)
src/ctl/src/cmd_impl/hummock/list_version.rs 0.00% <0.00%> (ø)
src/ctl/src/cmd_impl/hummock/sst_dump.rs 0.00% <0.00%> (ø)
src/ctl/src/lib.rs 1.44% <0.00%> (-0.05%) :arrow_down:
src/expr/src/vector_op/agg/aggregator.rs 60.57% <0.00%> (-0.35%) :arrow_down:
src/frontend/src/handler/explain.rs 0.00% <ø> (ø)
src/frontend/src/handler/query.rs 0.00% <0.00%> (ø)
src/frontend/src/handler/variable.rs 0.00% <ø> (ø)
...frontend/src/scheduler/hummock_snapshot_manager.rs 20.70% <0.00%> (-1.46%) :arrow_down:
... and 41 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Sep 21 '22 08:09 codecov[bot]

Because we use a fixed instance to run the test, there is a lack of some necessary cleanup, such as kafka/checkpoint/nexmark data.

huangjw806 avatar Sep 26 '22 09:09 huangjw806

Because we use a fixed instance to run the test, there is a lack of some necessary cleanup, such as kafka/checkpoint/nexmark data.

We will add the cleanup in next iteration. @lmatz will provide the same and I will add it here,

sumittal avatar Sep 26 '22 10:09 sumittal

Why do we need to run Flink benchmark in RisingWave's pipeline? 🤣 Suggest moving this out to risingwave-test.

skyzh avatar Sep 26 '22 20:09 skyzh

peline? 🤣 Suggest moving this out to risingwave-test.

Currently buildkite is only free for open source projects, we have planned to reopen a buildkite account, and then migrate benchmark-related workflows to risingwave-test repo. https://github.com/risingwavelabs/risingwave-test/issues/38

huangjw806 avatar Sep 27 '22 01:09 huangjw806

Currently buildkite is only free for open source projects

Hope this is not an abuse of Buildkite open-source program 🤣 I'm fine with that.

skyzh avatar Sep 27 '22 01:09 skyzh