risingwave icon indicating copy to clipboard operation
risingwave copied to clipboard

feat(ctl): list pinned hummock versions and snapshots

Open zwang28 opened this issue 1 year ago • 1 comments

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

Add list_pinned_versions and list_pinned_snapshots command for risectl.

Sample output

./risedev ctl hummock list-pinned-versions

Worker 1 type 2 min_pinned_version_id 208
Worker 2 type 2 min_pinned_version_id 208
Worker 3 type 2 min_pinned_version_id 208

./risedev ctl hummock list-pinned-snapshots

Worker 4 type 1 min_pinned_snapshot 3060628331102208

Checklist

  • [x] I have written necessary rustdoc comments ~~- [ ] I have added necessary unit tests and integration tests~~
  • [x] All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

If your pull request contains user-facing changes, please specify the types of the changes, and create a release note. Otherwise, please feel free to remove this section.

Types of user-facing changes

Please keep the types that apply to your changes, and remove those that do not apply.

  • Installation and deployment
  • Connector (sources & sinks)
  • SQL commands, functions, and operators
  • RisingWave cluster configuration changes
  • Other (please specify in the release note below)

Release note

Please create a release note for your changes. In the release note, focus on the impact on users, and mention the environment or conditions where the impact may occur.

Refer to a related PR or issue link (optional)

https://github.com/risingwavelabs/risingwave/issues/5516

zwang28 avatar Sep 23 '22 12:09 zwang28

Codecov Report

Merging #5532 (899b133) into main (5587547) will decrease coverage by 0.06%. The diff coverage is 56.39%.

@@            Coverage Diff             @@
##             main    #5532      +/-   ##
==========================================
- Coverage   74.26%   74.20%   -0.07%     
==========================================
  Files         906      907       +1     
  Lines      142634   143136     +502     
==========================================
+ Hits       105925   106209     +284     
- Misses      36709    36927     +218     
Flag Coverage Δ
rust 74.20% <56.39%> (-0.07%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/ctl/src/cmd_impl/hummock/list_kv.rs 0.00% <0.00%> (ø)
src/ctl/src/cmd_impl/hummock/list_version.rs 0.00% <0.00%> (ø)
src/ctl/src/cmd_impl/hummock/sst_dump.rs 0.00% <0.00%> (ø)
src/ctl/src/lib.rs 1.44% <0.00%> (-0.05%) :arrow_down:
...frontend/src/scheduler/hummock_snapshot_manager.rs 20.70% <0.00%> (-1.46%) :arrow_down:
src/meta/src/hummock/manager/versioning.rs 62.12% <0.00%> (-33.23%) :arrow_down:
src/meta/src/rpc/service/hummock_service.rs 5.28% <0.00%> (-0.68%) :arrow_down:
src/rpc_client/src/meta_client.rs 0.00% <0.00%> (ø)
src/storage/src/hummock/mod.rs 92.63% <ø> (ø)
src/storage/src/hummock/shared_buffer/mod.rs 90.97% <ø> (ø)
... and 8 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Sep 23 '22 12:09 codecov[bot]

LGTM. Let's merge?

skyzh avatar Sep 26 '22 04:09 skyzh