Stephen Kitt
Stephen Kitt
/remove-lifecycle rotten
/ok-to-test
BTW once the structure is ready (which it probably is), you need to run `make update-toc` and include the changes that produces.
A couple of minor points left to address, but this is looking good, thanks @ryanzhang-oss! Could you squash the commits before we merge this?
Thanks! /approve Technically this still needs an LGTM from a member, @mikemorris would you care to do the honours, assuming the PR meets with your approval?
It’s fine to do these two changes in a single PR (as two separate commits), thanks. But it seems to me the merge is going in the wrong direction: here...
/remove-lifecycle stale
I haven’t checked this PR specifically, but I maintain other Python projects that have switched to `pyproject.toml` without `setup.py` without difficulty, so this should be fine.
> Hello @skitt, could you sign the CLA? Sorry, I missed that part of the contribution workflow — I’ll have to get approval from our legal department.