about-api icon indicating copy to clipboard operation
about-api copied to clipboard
verified publisher icon kubernetes-sigs

chore: Upgrading Kubebuilder to V4

Open holgerson97 opened this issue 10 months ago • 4 comments

My motivation for this PR is this discussion: Kubebuilder Discussion #3907 I also want to move the scaffolding into the root directory, is this something that is ok to be done in one PR?

holgerson97 avatar Mar 11 '25 08:03 holgerson97

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: holgerson97 Once this PR has been reviewed and has the lgtm label, please assign lauralorenz for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Mar 11 '25 08:03 k8s-ci-robot

It’s fine to do these two changes in a single PR (as two separate commits), thanks. But it seems to me the merge is going in the wrong direction: here everything is added in clusterproperty, I would have thought everything would end up in the root directory.

skitt avatar Mar 18 '25 17:03 skitt

It’s fine to do these two changes in a single PR (as two separate commits), thanks. But it seems to me the merge is going in the wrong direction: here everything is added in clusterproperty, I would have thought everything would end up in the root directory.

@skitt I think my question was not straightforward enough, basically it was about the rescaffolding in this PR, I added now the changes in 7c82e36

holgerson97 avatar Mar 20 '25 09:03 holgerson97

we still need the generated client

qiujian16 avatar May 27 '25 02:05 qiujian16

@skitt sorry for this taking so long, can you rereview?

holgerson97 avatar Aug 20 '25 06:08 holgerson97

actually we need the generated client, it cannot be deleted. I have another PR that to update the existing one right now...https://github.com/kubernetes-sigs/about-api/pull/31

qiujian16 avatar Aug 20 '25 08:08 qiujian16

/sig multicluster

lauralorenz avatar Sep 03 '25 16:09 lauralorenz

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Dec 02 '25 17:12 k8s-triage-robot

/remove-lifecycle stale

skitt avatar Dec 02 '25 17:12 skitt