Stephen Kitt

icon company @redhatofficial icon location Lyon, France

Results 103 comments of Stephen Kitt

Skip RunAndReturn() on functions with no returns

Right, that makes sense.

POC new package for formal conformance tests

/remove-lifecycle stale

pkg/api(s): drop pointer wrapper functions

/retest-required

pkg/api(s): drop pointer wrapper functions

/remove-lifecycle stale

pkg/api(s): drop pointer wrapper functions

/remove-lifecycle stale

pkg/api(s): drop pointer wrapper functions

/reopen

Initial implementation of skupper debug check

I’ve updated this to add `skupper debug check` (but no additional checks yet).

Use generics to share code in fake client-go implementations

There’s no rush on this, it’s obviously not appropriate for 1.31 at this stage. /cc @thockin @jpbetz

Use generics to share code in fake client-go implementations

> @skitt Are you hoping to land this in 32? If so, rebase and I can try to look tomorrow. Might as well, I’ve rebased it and regenerated the fakes.

Use generics to share code in fake client-go implementations

The flakiness in https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/126503/pull-kubernetes-verify/1854520541428322304 is surprising: it should always fail (the generated code wouldn’t compile).