skirtle comments

Results 147 comments of


                                            skirtle

fix(transition): get root el of DEV_FRAGMENT_ROOT

I think this may have been fixed in 3.4.22 by #9421.

feat(complier-sfc): add `hoistStatic` for `<script setup>`

I think this may have introduced a regression: #7973. I'm not sure of the cause, but testing locally it seems to work fine prior to this being merged.

feat(runtime-core): return result of handlers in `emit`

There's an RFC discussion at that proposes a slightly different way of approaching this. I'm not sure which I prefer. --- Just to clarify, a single event can have multiple...

Pinia for Vue SFC Playground

I've opened a PR to make using Pinia with the SFC Playground a little less troublesome: #7311. See the example link at the top of the PR.

linkfix: vitejs/vite-plugin-vue2

I'm not sure what the best course of action is here. The current link does work. For anyone using Vue 2.6 I believe that would still be the correct plugin....

fix(runtime-core): warn about negative number in v-for

Yes, I meant adding tests to confirm that `0` renders nothing, without a warning or error. Your code contains a boundary condition of `source < 0`. Currently you've tested one...

docs: add bun command examples

Similar to #2089. I understand why that PR was closed, but the core Vue docs do include similar instructions for `bun` at .

fix(reactivity): avoid error during nested watch stop

I still think there's a problem with the testing here. The test confirms that stopping the `effectScope` doesn't throw an error, but it doesn't confirm that the watchers actually get...

fix: ensure tracking is paused when emit() calls handler so it can safely be called in effects (fix #6669)

Just in case this does get merged, I think the same change would need to be applied to the `onceHandler` a bit further down. --- As for whether it should...

Update KeepAlive.ts

Related: #5105.