skirtle comments

Results 147 comments of


                                            skirtle

fix(server-renderer): Make sure dir is defined

> In this case, is there a reason to update it? I think so, yes. The similar change in #6671 also updated the types. The function `resolveDirective` has return type...

fix(types): Type 'enter' and 'tab' is not assignable to type 'VOnModifiers'

I don't think `enter` and `tab` should be added to `keyNames`. That object is specifically used to map aliases, so it shouldn't include any values that map to themselves. That...

fix(runtime-dom): undefined cssvars should not be bound to the element

There's also a potential problem with components that render recursively. If the inner component doesn't set the variable then it will be inherited from the outer component: - [Playground](https://deploy-preview-7475--vue-sfc-playground.netlify.app/#eNp9Uk1P3TAQ/Csrt1IeEiSoqJc0VGorDuUACDj6EuLNw5DYlu2EoCj/nbXNCx8Cbrs769nZHc/sjzH5OCArWeUaK40Hh34wv7mSvdHWwwwWW1igtbqHjFqzFfqne/Ncz4uQBCaCuWq0ch5utBVo4TgwbLIfZgKnOyngW3t4mO1xVRVpJA2jxGNvutpjyHwVucvEcMxZCjiDguCqWHvZPvOOprVym985rWiPmSsAzhoikB3ac+MlqeGshIgErO46/XAaa94OuL+rN7fY3H9Qv3NTqHF2YdGhHZGzFfO13aJP8MnVGU4Ur2CvxdBR9xfgJdJRhqAxtf0dlCDZr/qi2v/x5FJtr93J5FG53VJBaOhcYj9nZEG43Werv8g9yo/iO64WuuLOvg8+gsBWKryw2rhN5ElmlHDlLQmi9195CVAJOULT1c6RkcEWrVCRhAgCzDN8N4EcFtISKsn88UC2750nrCC2t38gTnT+sQthvg5IO++0jgc3UolNlvJs71cATS0EbVDCTzNRgcbTGpGILU8tgQuP) Setting...

fix(runtime-core): expose type using generics

Does this replace #8507?

feat(compiler-core): allow directive modifiers to be dynamic (fix #8281)

This feedback might be better placed on an RFC. I'm not aware of an RFC for this feature, so I've added it here instead. --- If I've understood correctly, this...

fix(compiler-sfc): auto add nesting selector for nesting ::v-deep

I think we'd also need to consider the case where the `&` is inside the `:deep()`. e.g.: ```css .foo { .bar :deep(&) { color: red; } } ``` - [Playground](https://deploy-preview-13163--vue-sfc-playground.netlify.app/#eNp9Uk1LAzEQ/SshB6tQdg96WldBS0EFP1CPuazJtE3NJiHJ1pbS/+4ka+qCtrCHzJv3hjfzdktvrC1WHdCK1p47aQPxEDp7zbRsrXGBPG4mC6kEmTnTklFR/tRRNGK6LnsV8rEI0FrVBMCKkFrIFeGq8f6K0Y/GMZpgbOSRZc8rkYivuhzIsfRho4B4biwIRIqZMWQbBQUOI5UAsKcnZz1ECDfKuIo4EJcR2DGNH7qLQ1BNxzTgKD2T82LpjcZ9k5BRblorFbhnG6TRntEqj2S0Ucp8PSQsuA7GGecL4J//4Eu/jhijLw48uBUwuu+Fxs0h9O3p2xOs8b1vtkZ0CtlHmq/gjeqix55222mBtge85PY+pSb1/N1P1wG0z0tFo+kyic8o5jc5svqv3fPiIl8UrziIP/4zfxLPGQ/Dx+Qw/DtAfznsA7HT3TcnctiK)...

feat: throw if parent and child routes have the same name

@sherleysong I don't fully understand your question, but you need to remove the `name: 'home'` from the parent route.

fix(css-vars): nullish v-bind in style should not lead to unexpected inheritance

I think this would also close #7474 and the associated PR #7475. --- There's an underlying question here about whether we consider `undefined` and `null` to be valid values for...

fix(css-vars): nullish v-bind in style should not lead to unexpected inheritance

TLDR: I think the latest proposal looks good. --- I wasn't initially clear about the difference between `initial` and `v-bind('"initial"')`, so I put together a Playground to help demonstrate: -...

fix(compiler-sfc): improve scoped style rewriting for nested and non-pseudo :is/:where selectors

I'm wondering about nesting `:is()` inside `:is()`: - [Playground](https://deploy-preview-12244--vue-sfc-playground.netlify.app/#eNqVUs1OwkAQfpXNehGC7UFPtZKIwUQPaNTjXpZ2KAvbnc3uFjCEd3e2CDb+kHho0n5/882kW35rbbJqgGc8D1BbLQMMhWEsL9WKFVp6fyP4DFHw4T1inhL8k59KR/xIugOfp50w+vThXQPzBVooCcmUP49PQsG9HtvGwBmacLEGVc1Dxqaoy2thdtF8Jq1l3x0s7bMJBrZGt1SmYv00ZhSo0WXMwac5T9vBnQ7d4dT6n8M7jr9H8QEPtKmZqSpZeDR02tYheIG1VRrckw0KjRc822dFTmqN68cWC66BwQEv5lAsf8EXfhMxwZ8deHArEPzIBekqCHt6/DqBDb0fyRrLRpP6BPkCHnUTO+5lo8aUVLuja9s+1BZdoOu/+fEmgPGHpWLRqNy1esHp/7o7sfpX3cvkqvXRRfnuA8gp3P4=) A selector like `:is(:is(.foo))` seems to be scoped correctly, but not `#app :is(:is(.foo))`.