v3-migration-guide icon indicating copy to clipboard operation
v3-migration-guide copied to clipboard

linkfix: vitejs/vite-plugin-vue2

Open simon04 opened this issue 3 years ago • 7 comments

simon04 avatar Dec 04 '22 12:12 simon04

Deploy Preview for eager-kowalevski-41f498 ready!

Name Link
Latest commit 79b2f6b04186d287968d61178376f6784c39fbc4
Latest deploy log https://app.netlify.com/sites/eager-kowalevski-41f498/deploys/6394c49240cbb600095e8498
Deploy Preview https://deploy-preview-30--eager-kowalevski-41f498.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Dec 04 '22 12:12 netlify[bot]

I'm not sure what the best course of action is here.

The current link does work. For anyone using Vue 2.6 I believe that would still be the correct plugin. It's also the plugin shown in the example application.

For those using 2.7, the old repo's README does clearly indicate that it is for 2.6, with a link to the newer plugin.

If we update the link to the newer plugin then we end up an inconsistency in the example. There's also no indication in the README for that repo that it is a successor to the older plugin.

Also, the names of the plugins are different, not just the GitHub repo. The new plugin is called @vitejs/plugin-vue2, rather than vite-plugin-vue2.

I'm wondering whether the wording here in the migration guide should be changed to provide full context and both links?

skirtles-code avatar Dec 05 '22 02:12 skirtles-code

Hi, oh, it's more complicated than I thought... What about:

(Alternative) migrate to Vite + @vitejs/plugin-vue2 (Vue 2.7) or vite-plugin-vue2 (Vue 2.6 or earlier).

simon04 avatar Dec 10 '22 17:12 simon04

Alternatively we could link to the corresponding section of the Vite docs: https://vitejs.dev/guide/features.html#vue

simon04 avatar Dec 11 '22 10:12 simon04

I personally suggest keeping the 2.6 as the main case since this is a migration guide. For 2.7 and the official plugin without a existing example to follow, I think we can add one more line behind additionally to describe.

What do you folks think?

Jinjiang avatar Dec 14 '22 02:12 Jinjiang

@sodatea @underfin any ideas about that? :-)

Jinjiang avatar Dec 14 '22 02:12 Jinjiang

Alternatively we could link to the corresponding section of the Vite docs: vitejs.dev/guide/features.html#vue

I think it's a good idea to link to the Vite docs, as it's a rather complicated situation 😅

Only mentioning the plugin for 2.6 or 2.7 seems inconsistent with other parts of the guide - the webpack guide is about the necessary dependencies to run Vue 3.

haoqunjiang avatar Dec 14 '22 07:12 haoqunjiang