Sergio Rey comments

Results 208 comments of


                                            Sergio Rey

adding alternative option in local_moran and moral_local_rate

These look like useful changes. Thanks. It would be helpful to add test coverage for new/changed functionality and update the documentation to surface these changes/enhancements.

WIP: Headbang re-work

@thequackdaddy thanks for this. certainly it is of interest if you want to finish it we will merge. modernizing/pruning the tests would be very helpful.

WIP: Headbang re-work

Here is some more documentation: https://surveillance.cancer.gov/headbang/

WIP: Headbang re-work

@thequackdaddy this is looking good - i will get a closer review in the coming days. One thing that comes to mind is whether we can assume `k` from the...

> we should be able to exploit `numpy.subtract.outer` and elementwise matrix multiplication to do the Geary statistic in a much faster fashion than our current list comprehension. Something like: >...

Standard docstring formatting conventions proposal

`pysal/pysal` makes sense to me

geary does hard typechecking of the weights object instead of ducktyping

Good catch. I agree that ducktyping these type of out-of-date conventions (now that we have refactored the library) is the way to go.

geary does hard typechecking of the weights object instead of ducktyping

Is this still an issue, since now we [import form libpysal](https://github.com/pysal/esda/blob/master/esda/geary.py#L8) to check the parameter class?

implement `.plot()`, `.scatterplot()` and `.lisa_map()` methods for `Moran_Local` object

@slumnitz I'm hitting an error trying to test this off of the branch `slumnitz:splot-method`: (All in a notebook but kludgy, so cut and paste here) ``` import matplotlib.pyplot as plt...

implement `.plot()`, `.scatterplot()` and `.lisa_map()` methods for `Moran_Local` object

@slumnitz can we close this?