Sergio Rey

Results 208 comments of Sergio Rey

@jGaboardi you are good to go.

> I have created a `from_dataframe_new` method to match the ideal outcome of the transition from `ids`, `idVariable` and `id_order` to a cleaner API. What needs to be figured out...

On a related note, turning off the sorting of the ids on init can be done. I explored this https://github.com/pysal/libpysal/commit/13c89b68038b5cf2b4bcf97abe1f14162b947ac0 and two tests broke in all of weights. These had...

> > So the plan would be to deprecate idVariable and id_order, while refactoring ids for a new api, correct? > > Yes. And figure out what to do with...

The timing for the changes might be something like this: For meta 23.01 released Jan 2023, deprecation warnings have been added for the old id-related api. We then target 23.07...

> Not sure I fully understand. Esp. this > > > Maintaining two api's seems like a painful route, so the above is suggested as a way to avoid this....

@TaylorOshan can you provide information on the license for the georgia and tokyo examples?

@Nilsonfsilva thanks for the issue, and the work on the packaging. I'll get you info on the license for pyShpIO.py when I hear back from the original dev.

Note, this is passing locally for me.