adding alternative option in local_moran and moral_local_rate

[tushar-corbic]

[sjsrey]

These look like useful changes. Thanks.

It would be helpful to add test coverage for new/changed functionality and update the documentation to surface these changes/enhancements.

[tushar-corbic]

@martinfleis @sjsrey , could you please tell me how to add test coverage for local_moran and moran_local_rate, Thank you

[ljwolf]

Hey! this is looking very good, well done @tushar-corbic!

how to add test coverage

Sure! Normally, we add a method to the test class for that module. For Moran_Local, that's in esda/tests/test_moran.py. If you follow that pattern to ensure that the test works, and reproduces the same result every time, then that should be fine!

[tushar-corbic]

Hey! this is looking very good, well done @tushar-corbic!

how to add test coverage

Sure! Normally, we add a method to the test class for that module. For Moran_Local, that's in esda/tests/test_moran.py. If you follow that pattern to ensure that the test works, and reproduces the same result every time, then that should be fine!

Thank you @ljwolf , I have added test coverage for local_moran. Thank you