Sjoerd Bouma

Focusing factor

3

I found a missing factor in the focusing factor used in NuRadioMC. This PR also fixed a couple of incorrect analytic formulas for the path length and travel time in...

The rnog_detector uses a singleton `Database`, meaning that re-initializing it (e.g. to create another database connection) does not work, as there was no way to pass the argument `create_new` to...

Change FFT normalization to exactly satisfy Parseval's Theorem

4

As briefly mentioned in #653, the NuRadioMC convention for the real DFT (rfft) does not actually satisfy Parseval's theorem exactly. We multiply all frequency components by $\sqrt{2}$; however, the 0-frequency...

generator.py does not take energy/flavor dependence into account when generating ccnc, inelasticities

5

In `generator.py`, when 'randomly' deciding whether a CC or NC interaction takes place, the code uses the `get_ccnc` function [here](https://nu-radio.github.io/NuRadioMC/_modules/NuRadioMC/utilities/inelasticities.html#get_ccnc). This corresponds to a constant ratio of CC : NC...

Missing factor in focusing factor & errors in analytic path length / travel time equations

4

While writing this up for my thesis (draft attached), I found 1. mistakes in the analytic formulas for the path length and travel time: Original:  Corrected:  These were...

Reading in a large detector from json is slow

13

Reading in a large detector description from a `.json` file is slower than expected; for the LOFAR detector description (O(1000) channels), reading in the json description using ``` det =...

`EvtGen` does not take neutrino interaction probability into account

34

Currently, when a user specifies a particular neutrino energy spectrum in `generator.py`, the distribution of event energies matches this flux. In simulation.py, these events are then weighted by their survival...

Python 3.6 compatibility

6

Currently, the unit tests fail on python 3.6 (see https://github.com/nu-radio/NuRadioMC/actions/runs/7884786760/job/21514540342). There seem to be two separate issues: - `NuRadioReco.detector.RNO_G.rnog_detector` uses `datetime.datetime.fromisoformat`, which was [only added in Python 3.7](https://docs.python.org/3/library/datetime.html#datetime.date.fromisoformat). This should...

Previously, the galactic noise adder generated random galactic noise for each channel. This PR expands the selection of available galactic sky models (thanks @karenterveer) and uses consistent galactic noise between...

Feature/arbitrary noise spectra

1

New feature - rather than simulating only flat noise spectra with the channelGenericNoiseAdder, I added the option to specify the desired frequency spectrum as a function of frequency. Note that...