Sjoerd Bouma

Results 97 comments of Sjoerd Bouma

The unit tests found a bug in my implementation for trajectories including bottom reflections. This should now be fixed, i.e. only the reference files and the changelog still need to...

So I've been over all the differences with the tests: - **Single event test (SP)**: the only difference is in the max_amp_shower_and_ray attribute. This difference is

One final comment - I reverted two commits that were workarounds for the air-to-ice raytracing. As this feature isn't currently working anyway (see #823 ) I removed them to reduce...

Ping @fschlueter or anyone who would like to approve this.

> Thanks Sjoerd! > > It all looks good to me, but it would be great if you could add additional documentation to the analytic travel time and distance functions...

@cg-laser I've added the equations and referred to my PhD thesis, which it felt very weird to do in the third person about myself.

@fschlueter #768 caused a merge conflict, which I've fixed; the difference to the reference Veff was a bit larger than I would have expected (~6%), but it looks like #768...

I'm not sure why the tests fail, but I don't have time to look into it right now. I'm semi-inclined to close this PR and instead live with satisfying Parseval's...

Closing this PR because - keeping track of the 'correct' normalization everywhere is a little bit cumbersome, and - 'flat' frequency spectra (white noise, delta pulses) would no longer be...

> * New logging format, which includes time (@sjoerd-bouma do you already have a nice format for this?) This is what I usually use: ``` logging.basicConfig(format="%(levelname)s:%(asctime)s:%(name)s:%(message)s", datefmt="%H:%M:%S") ``` which results...