Matt Martz

Results 336 comments of Matt Martz

I've also run it using a `test_timeout` ranging from `0.1` to `3.0` in `0.1` increments, 3 times through, and without a single failure. Just putting my guessing hat on, it's...

The github GUI did something amazing to resolve the merge conflict, and squashed and merged leaving only the merge commit with the change inside somehow. You'll have to rebase and...

I would not advise using an example that references `ansible.cfg` as the source of what indicates the root of a project. Our general consensus, is that config dependent content is...

There are no tests here, maybe I'll add them? Or maybe not since I'm deprecating them on adding. I should at least test that they work, which I have not...

`version_added` test failing is expected. Copied the configs from the ssh plugin, since they originally matched.

> It looks like the vyos incidental tests pass if the ansible.builtin NetworkConnectionBase also adds the `get_options` fix from ansible.netcommon [ansible-collections/ansible.netcommon@130c49e](https://github.com/ansible-collections/ansible.netcommon/commit/130c49ea32afea5807e2c733599a3e6a4da8baaa). Hrm, weird, I tested locally and at least the...

Super weird. First, I was confused, since https://github.com/ansible/ansible/pull/78789 is what I thought this PR was for a moment. Second, I'm now confused by why this change causes issues for the...

Alright, must have just been flaky. vyos tests passed this time.

The problem here is somewhat complex, but is effectively the expected behavior. When you specify `mode: 0770`, pyyaml detects this as an octal, but since Python does not have a...